Workflow: Disapprove / Reject "type: approval" | Feature Requests

Workflow: Disapprove / Reject "type: approval"

Shane Daniel

On some projects, we run unit tests, then "fan out" to have deployment steps per environment, each with its own approval step. Currently there is no way to reject; only "approve" or "cancel" (where cancel is a no-op and leaves the job open subject to approval)
While this works, and allows us to deploy to multiple environments when desired, it would be nice to be able to reject or disapprove explicitly so that the job does not remain "On Hold".
CCI-I-486

July 5, 2018

Fernando Abreu

This feature has been released! 🎉
Check out the changelog for more details: https://circleci.com/changelog/cancel-approval-jobs/
We’d love to hear your feedback—let us know your thoughts!

Javid Ali

Any update on this? Thanks.

Gleb Stsenov

Cancelled workflows look weird. I want to be able to disapprove explicitly, while still having the job green.

Karol Wnuk

Just spent a day trying to figure out how to do it. Now I know it's not possible :/

Tom Haratyk

+1 really missing this feature!!!

Javid Ali

+1 hoping this would resolve the issue

here https://discuss.circleci.com/t/circle-ci-status-ignoring-github-branch-protection-rules/36843 - where we can get a green tick on Github

Keith Homco

+1, Having a gatekeeping approval/reject step would allow a separate department (ex. QA) the ability to pass/fail a workflow so decisions could be made on actions to take (notifications, rollback/remove artifacts, etc). At a bare minimum, it would be nice to be able to cancel the approval job via the API. With that, I could have 2 parallel approval jobs labeled "approve" and "reject" respectively with corresponding downstream jobs; the "reject" could trigger a cancel on the other on_hold "approve" job so that it cannot continue and then fail or cancel the whole workflow. The "approve" could cancel the on_hold "reject" job and then continue to deploy/notify/etc.

Bruno Ferreira

+1, this would be really handy

adam soto

Any updates on this really wanted feature?

Kristian Hamre-Os

+1 for this feature

→