When using 'Auto-cancel redundant builds', don't mark builds that are canceled as failed
J
Jeffpotter Circleci
When a build is cancelled because a newer build is started, and 'Auto-cancel redundant builds' is enabled, the original job is marked as failed. This leads to confusion in looking at commit history in Github -- the redundant builds get marked as failed.
Doing this would require working with GitHub to add 'canceled' into their status state (see https://developer.github.com/v3/repos/statuses/)
CCI-I-752
Adam Harvey
As a counterpoint to this, if I push,
SHA123 - 11:01 am
SHA456 - 11:05 am
And CCI auto-cancels my job on SHA123, I think I actually do want the status check marked failed. GitHub has a basic commit status success or failure, and then status check details could more detailed if necessary. (I don't know if there's a conclusion status that matches skipped tho: https://docs.github.com/en/pull-requests/reference/status-checks#check-statuses-and-conclusions )
But if the SHA123 which was cancelled (effectively skipped) accidentally reported success, that might allow a user of mine to merge in code which may not have been tested. So I'd almost vote this one down.