115
Show overall "All checks have passed" status in github even on builds with incomplete "type: approval" job
L
Lydia Stepanek
I added a manual approval "trigger_rollback" job recently to my Circle 2.0 workflow and did not like the UI integration with github. On builds where I did not trigger this optional "trigger_rollback" job, the overall Github status was "Some checks haven't completed yet." (See screenshot.)
I talked to CircleCI support and they told me to deselect the status check for a "type: approval" job as described in this github article: https://circleci.com/docs/2.0/workflows-waiting-status/, which I had already done.
I still need the "trigger_rollback" job and corresponding status check. The "trigger_rollback" status check is type:approval, so I want it to be pending but I don't want the overall PR status to be pending -- instead I want the overall PR status to be green and say "All checks have passed."
CCI-I-445
Activity
Newest
Oldest
Michael Thomas
+1 How can this not be implemented yet?
Merged in a post:
Mark builds as success on github, even if there is an approval step
N
Norbert Kéri
Migrated from https://discuss.circleci.com/t/pull-request-checks-on-github-are-stuck-in-in-progress-because-of-type-approval-step/26617
Currently, if you have a workflow with a
type: approval
job, the pull requests will always be stuck in in a "pending" state, with a yellow checkmark on the github PR page, until someone approves/rejects the build on CircleCI.It would be great if the approval step could somehow be marked as irrelevant to the final outcome of the build, so that if all the other jobs for the pull request finish successfully, the PR would be marked as green.
CCI-I-984
Merged in a post:
Don't Show Yellow Status on GitHub for Jobs Require Manual Approval
S
Sign Of The Wolf Pentagram
Current Behavior
On GitHub, Manual Approval jobs which are not approved is shown as an yellow status.
Expected Behavior
Don't show the yellow (or any) status for such jobs.
Why?
If the status is indicated with yellow, the Pull Request looses attentions because people thinks it's incomplete.
CCI-I-507
Patrick Hübl-Neschkudla
I'm surprised that there is still no word on this feature. The missing option to mark manual approval steps as optional makes our circleci workflows basically incompatible with many 3rd party services (codecov is also not commenting on prs until the workflow is marked as completed).
M
Mykhailo Chalyi
+1, renders impossible optional jobs :(
T
Tyler
Is there any capability around this? This is really valuable for us as well, otherwise all of our successful builds look yellow instead of green.
j
jacopo beschi
+1 Having the same issue in our workflow
M
Matthieu D
Any chance to have an update on this?
This seems like an easy fix, proposals in merged ideas make sense.
In my mind, something like this would be ideal:
report: {true,false,always-success}
The lack of such a feature makes it super painful to use approval jobs today w/ GitHub - using them implies losing useful UX there.
J
James Pike
Not having this feature means we cannot consider CircleCI.
A
Arthur Lysenko
+1. We need this feature in our Github integration.
Load More
→