182
Show overall "All checks have passed" status in github even on builds with incomplete "type: approval" job
under review
L
Lydia Stepanek
I added a manual approval "trigger_rollback" job recently to my Circle 2.0 workflow and did not like the UI integration with github. On builds where I did not trigger this optional "trigger_rollback" job, the overall Github status was "Some checks haven't completed yet." (See screenshot.)
I talked to CircleCI support and they told me to deselect the status check for a "type: approval" job as described in this github article: https://circleci.com/docs/2.0/workflows-waiting-status/, which I had already done.
I still need the "trigger_rollback" job and corresponding status check. The "trigger_rollback" status check is type:approval, so I want it to be pending but I don't want the overall PR status to be pending -- instead I want the overall PR status to be green and say "All checks have passed."
CCI-I-445
Activity Feed
Sort by
Federico Terzi
While we wait for the official solution, I managed to find a workaround to solve this very annoying issue based on the GitHub Commit Status API. I wrote an article about it if you're interested :)
https://federicoterzi.com/blog/solving-github-status-stuck-on-pending-with-circlecis-approvals
Finally we got the green checks back!
Nathan Broadbent
Federico Terzi: Thanks so much for your script, it works great! It's so nice to see green check marks and "All checks have passed" on GitHub.
Federico Terzi
Nathan Broadbent: Thanks :) Glad you found it useful!
Kim Yu Ng
Oran Bartell Would the improvement to Github checks cover the similar problems encountered in conditional workflow as well?
Currently if any conditional workflow is being skipped, it's possible to merge but the problem is that it stucks in "waiting for status to be reported" as well as shown in first three lines on the following picture.
The expected behavior is if the conditional workflow is being run, it should be required to be successful. However, if it's being skipped completely, it should either report it to Github successfully or smart enough not showing it up as a requirement in Github.
Oran Bartell
Kim Yu Ng: Thanks for sharing this example. Statuses for conditional workflows would be a separate update from approval job statuses, but I'll be sure to explore this as part of the overall improvements project.
Oran Bartell
under review
Improvements to Github statuses, including Github Checks, are being considered for the second half of 2022. This idea will move to "planned" once a timeline is established.
Oran Bartell
Merged in a post:
Ignoring "hold" jobs Status in GitHub
F
François Wouts
Add the ability to ignore status updates for specified jobs. The use case for this is that we have an on-hold job that is optional. In GitHub it shows that the PR is still pending and 6/7 checks have completed.This doesn't prevent us from merging PRs. It just prevents us from knowing which PRs were successful at a glance (without opening the details).
CCI-I-808
R
Reydi Sutandang
any update on this?
R
Reydi Sutandang
Liya Ai
Jonathan Cardoso
Right now this is a major blocker for us to migrate to CircleCI
Lawrence Song
I love many features on circle ci. However, without this I cannot use "type: approval" feature because my PR cannot be merged without circle ci check is green. I think many ppl will move away if this feature is not implemented.
Lawrence Song
We really need this support to get our pull request flow going. Please fix this or provide a workaround.
J
Javid Ali
Hiya - please let me know if this was implemented as we're looking forward to our Github statuses to work as expected when tests pass. Thanks.
Westbrook Johnson
Bump! Super valuable.
Load More
→